feat: support volume configuration, provisioning, etc. #8901
+13,525
−3,775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smira
force-pushed
the
feat/volume-config
branch
2 times, most recently
from
e09fea0
to
4d3cd8c
Compare
smira
force-pushed
the
feat/volume-config
branch
4 times, most recently
from
2f1a743
to
3128bf7
Compare
frezbo
reviewed
Jul 23, 2024
smira
force-pushed
the
feat/volume-config
branch
3 times, most recently
from
d976f7f
to
e848274
Compare
smira
force-pushed
the
feat/volume-config
branch
2 times, most recently
from
06023fd
to
542a9b7
Compare
smira
commented
Aug 15, 2024
internal/app/machined/internal/server/v1alpha1/v1alpha1_server.go
Outdated
Show resolved
Hide resolved
internal/app/machined/internal/server/v1alpha1/v1alpha1_server.go
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
smira
force-pushed
the
feat/volume-config
branch
4 times, most recently
from
7b1daf5
to
8dae199
Compare
smira
force-pushed
the
feat/volume-config
branch
from
8dae199
to
05647fb
Compare
smira
force-pushed
the
feat/volume-config
branch
8 times, most recently
from
0bbbcf7
to
06e2be1
Compare
frezbo
reviewed
Aug 29, 2024
frezbo
reviewed
Aug 29, 2024
smira
force-pushed
the
feat/volume-config
branch
from
50d09ee
to
d865daa
Compare
|
will we have a use case where the old wipe option on upgrade is needed 🤔 ? |
smira
force-pushed
the
feat/volume-config
branch
from
d865daa
to
327b24b
Compare
I don't think so -- Omni runs with One could still wipe volumes via |
smira
force-pushed
the
feat/volume-config
branch
2 times, most recently
from
32a9d66
to
7b1a53f
Compare
frezbo
approved these changes
Aug 30, 2024
smira
force-pushed
the
feat/volume-config
branch
from
7b1a53f
to
40857b3
Compare
Unix4ever
approved these changes
Aug 30, 2024
This implements the first round of changes, replacing the volume backend with the new implementation, while keeping most of the external interfaces intact. See siderolabs#8367 Signed-off-by: Andrey Smirnov <[email protected]>
smira
force-pushed
the
feat/volume-config
branch
from
40857b3
to
b453385
Compare
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the first round of changes, replacing the volume backend
with the new implementation, while keeping most of the external
interfaces intact.
See #8367