chore: drop console ttyS0 argument.
#9222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frezbo
force-pushed
the
chore/drop-ttyS0-metal-image
branch
2 times, most recently
from
3df69b9
to
25f9c8f
Compare
smira
reviewed
Aug 26, 2024
frezbo
force-pushed
the
chore/drop-ttyS0-metal-image
branch
from
25f9c8f
to
9c9f25e
Compare
smira
reviewed
Aug 27, 2024
smira
reviewed
Aug 27, 2024
smira
reviewed
Aug 27, 2024
frezbo
force-pushed
the
chore/drop-ttyS0-metal-image
branch
from
9c9f25e
to
91ddc11
Compare
frezbo
commented
Aug 27, 2024
Drop `console=ttyS0` argument for metal images/installer. `console=ttyS0` causes lot of issues with bare metal hardware when trying to use a physical serial port. Ref: * https://bugzilla.redhat.com/show_bug.cgi?id=1839923 * https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=763601;msg=17 * https://www.kernel.org/doc/html/latest/admin-guide/serial-console.html * coreos/fedora-coreos-tracker#567 Fixes: siderolabs#8695 Fixes: siderolabs#8657 Fixes: siderolabs#8127 Signed-off-by: Noel Georgi <[email protected]>
frezbo
force-pushed
the
chore/drop-ttyS0-metal-image
branch
from
91ddc11
to
19a44c2
Compare
smira
approved these changes
Aug 28, 2024
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop
console=ttyS0argument for metal images/installer.console=ttyS0causes lot of issues with bare metal hardware when trying to use a physical serial port.Ref:
Fixes: #8695
Fixes: #8657
Fixes: #8127