-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: audit and fix cgroup reservations #9341
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smira
force-pushed
the
fix/cgroups-reservation
branch
2 times, most recently
from
September 20, 2024 16:05
ed43698
to
1a2652d
Compare
Controlplane:
|
Worker:
|
frezbo
reviewed
Sep 20, 2024
smira
force-pushed
the
fix/cgroups-reservation
branch
from
September 20, 2024 16:25
1a2652d
to
8e0d5cd
Compare
frezbo
approved these changes
Sep 20, 2024
Unix4ever
reviewed
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🆒
Unix4ever
approved these changes
Sep 20, 2024
Fixes: siderolabs#7081 Review all reservations and limits set, test under stress load (using both memory and CPU). The goal: system components (Talos itself) and runtime (kubelet, CRI) should survive under extreme resource starvation (workloads consuming all CPU/memory). Uses siderolabs#9337 to visualize changes, but doesn't depend on it. Signed-off-by: Andrey Smirnov <[email protected]>
smira
force-pushed
the
fix/cgroups-reservation
branch
from
September 20, 2024 18:22
8e0d5cd
to
6b15ca1
Compare
/m |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7081
Review all reservations and limits set, test under stress load (using both memory and CPU).
The goal: system components (Talos itself) and runtime (kubelet, CRI) should survive under extreme resource starvation (workloads consuming all CPU/memory).
Uses #9337 to visualize changes, but doesn't depend on it.