-
-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promise Pool: Inconsistent types, missing releaseConnection function #1563
Comments
You're right, it is. Couldn't find it in the documentation. What about the types for |
I think the promise wrapper is increasingly becoming the most popular api and deserve place at the beginning of readme, while callback style api can reuse documentation from
looks like it's outdated, now deprecated |
@perry-mitchell would you like to contribute a fix to missing typings? If you can think of some test harness that would be awesome ( have a unit test in TS that can both run without runtime errors and pass static type checks ) |
I'll close this one as we also discuss same issue in #1761 |
Hi,
I'm looking at implementing a connection pool, using the promise entry, but as I can see here there isn't a
releaseConnection
function.Additionally, when looking at the standard connection pool types, the
releaseConnection
method is not typed at all.The text was updated successfully, but these errors were encountered: