fix: releaseConnection types and promise #2053
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the #1761 and #1563.
JS
The promise.js didn't have the method
releaseConnection
.Instead of creating from scratch, I just "extended" it from the
release
method:Then, I added the test to test/integration/promise-wrappers/test-promise-wrappers.js.
TS
I had to fix a few wrong types before to fix the
releaseConnection
.Before this PR, according by typings, this should be possible:
So, I fixed it to only
Pool
have the methodgetConnection
.tsc-build
to ensure that the above code doesn't occur again.Lastly, I added some tests for each method that I changed something in types:
releaseConnection
release
getConnection
connection