-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multi-reply handlers #92
base: master
Are you sure you want to change the base?
Conversation
so the callback decides when last packet arrives? Looks wrong to me, should be in the handler code |
fd9912e
to
624e8df
Compare
Introduced |
Should I rename the callback to |
Hey @aselivanov sorry this was silent for months. @santigimeno maybe you could assist? |
if (client.options.debug) | ||
delete client.seq2stack[seq_num]; | ||
delete client.replies[seq_num]; | ||
if (client.options.debug) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix indentation
@sidorares sure |
303cda6
to
b382768
Compare
@sidorares Now it's possible to keep handlers as needed. For example, to track input events with a Record extension (e.g. EnableContext):