Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with try catch #24

Closed
maratfakhreev opened this issue May 29, 2016 · 6 comments
Closed

Error with try catch #24

maratfakhreev opened this issue May 29, 2016 · 6 comments

Comments

@maratfakhreev
Copy link
Contributor

With version 1.0.4 my application has started to throw next errors:
screen shot 2016-05-29 at 14 51 21

I have found problem in these lines of code:
179c4b5#diff-168726dbe96b3ce427e7fedce31bb0bcR114

Any ideas? I just do not fully understand the meaning of this code block.

@sidorares
Copy link
Owner

would it be easy to create a minimal fully self contained example?

@maratfakhreev
Copy link
Contributor Author

Each .pug file throws this error, it doesn't look like some syntax error. You can find all templates here.
And as I said below if comment lines 115-120 it works correctly as works version 1.0.3.

@sidorares
Copy link
Owner

@deedw could you have a look? It seems that sometimes try { line is there but catch is removed

@deedw
Copy link
Contributor

deedw commented May 29, 2016

@maratfakhreev Which version of jade/pug are you using?

@maratfakhreev
Copy link
Contributor Author

maratfakhreev commented May 30, 2016

@deedw @sidorares Actually I don't define versions of jade/pug in my package.json but they installed as dependencies for another libs. So pug has latest versions but jade has 0.24.x and the problem seems to be in this. After I installed latest version manually everything worked correctly. So, thank you for the idea)

But to avoid this issue and in case of npm 3 jade must be placed in dependences not in peerDependencies, especially b/c it has required inside the index file. I can prepare PR with this change if you agree with my solution.

@maratfakhreev
Copy link
Contributor Author

Refer to #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants