Move jade to dependencies #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "source-map": "~0.5.3", | ||
| "browserify-transform-tools": "~1.6.0", | ||
| "convert-source-map": "~1.2.0", | ||
| "jade": "~1.11.0", |
There was a problem hiding this comment.
should we switch to https://www.npmjs.com/package/pug ?
There was a problem hiding this comment.
I actually tried to use pug and tried to replace all jade requires inside index.js with latest pug release but it doesn't work. Looks like migration on pug a more complex task than simply replace jade on pug. And this is the issue for major release I think.
There was a problem hiding this comment.
@sidorares ping
There was a problem hiding this comment.
ok, let's leave jade until resolved
|
lgtm with one comment |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #24 and #25 need to move jade from
peerDependencies.The first main reason is that it doesn't install via npm3 and therefore tests fall (have tried after
git clone).The next reason is that in big project application can be installed with wrong jade version and therefore brokes at the start.