Rewritten core, bugfixes and ES2015 #19
Conversation
| } | ||
| function generateSourceMaps (src, compiled, file) { | ||
| const lines = compiled.split('\n') | ||
| const generator = new SourceMapGenerator({ file: `${file}.js` }) |
There was a problem hiding this comment.
I know it was in the old version also, but why do we need to add .js to the filename?
There was a problem hiding this comment.
can't remember why, need to test if browser is happy without .js ( and how file parameter is used )
|
Added a few comments. Nothing major. The This pr also remove the |
|
Sorry to butt in, but is this project active at all? I was meaning to use it, but such a major PR stopped since February 2016 kinda dissuaded me. I'm making a major rewrite of a big project, and was thinking of changing from jade to pug in it, and so going from jadeify to pugify, but this situation smells like trouble like this. |
|
@herzinger it's not very active but I'm keen to maintain it Do you want to hellp with this pr? To start we need to pull https://github.com/izolate/pugify.git#esnext and rebase it |
Started as basic upgrade to ES2015, but turned into a full re-write as @tellnes suggested in #17. Builds on my previous PR in order to completely replace Jade with Pug. Due to breaking changes, recommend a
2.0.0major release.Changes
5.x)< 1.0(added 3 years ago). Reasoning being, Pugify2.xdepends on Pug, which is equivalent to the latest Jade version. Backwards compatibility can be achieved by using Pugify1.x.Sorry for the hefty PR. I appreciate your thoughts on this. I'll be sticking around to pick up any issues, especially as the Jade -> Pug transition completes.
As this is now the main
pugifyon npm, I think we have a moral imperative to keep the codebase clean, up-to-date and bug-free.