do not catch SIGINT under pytest

When running under pytest, we must not register a signal handler for SIGINT (CTRL-C), as otherwise the pytest internal signal handling does not work. This was also the root-cause, why we could not properly terminate our tests by pressing CTRL-C. Without that handler, the SIGINT raises a KeyboardInterrupt, which is handeled by pytest and either stops the test execution or prints a precise stacktrace of the current execution (which is valuable for debugging hanging tests). Signed-off-by: Felix Moessbauer <[email protected]> Signed-off-by: Jan Kiszka <[email protected]>
siemens · Oct 23, 2024 · b847390 · b847390
1 parent 8b064af
commit b847390
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/kas/kas.py b/kas/kas.py
@@ -192,8 +192,10 @@ def kas(argv):
 
     loop = asyncio.get_event_loop()
 
-    for sig in (signal.SIGINT, signal.SIGTERM):
-        loop.add_signal_handler(sig, interruption)
+    loop.add_signal_handler(signal.SIGTERM, interruption)
+    # don't overwrite pytest's signal handler
+    if "PYTEST_CURRENT_TEST" not in os.environ:
+        loop.add_signal_handler(signal.SIGINT, interruption)
     atexit.register(_atexit_handler)
 
     try: