fix-cert-and-token #109
Merged
fix-cert-and-token #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luigibarbato
added
bug
|
@billyen2012 Thank you very much for your contribution, Awesome work! 💪🏾🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, this
permission manageris extremely useful tool! It really made life easy.However, it seems to have issue generate token and cert. (Not sure if anyone else also experienced the same but it will just got stuck after I clicked on the
show kubeconfigbutton.)I've made some changes that will fix the issue.
Also, I made a change to the workflow, so instead generate token from the service account, a
Secretwith typekubernetes.io/service-account-tokenwill be created.In this way, user can trace how many tokens have been issued and invalidate any token anytime they want to.