Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Kubeconfig in UI missing certificate-authority-data value #90

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

Al-Pragliola
Copy link
Contributor

fixes #89

this bug was introduced in version v1.7.1-rc1, the string from CAData can be empty at times and in the previous version a fallback to CAFile was present, so I just reintroduced it.

This branch is taken from the commit 1ba5bcf so we can tag it as v1.7.2 (in branch fix-issue-89) without getting all the fixes scheduled for version 2.0.0

Copy link
Member

@ralgozino ralgozino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@angelbarrera92 angelbarrera92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kubeconfig in UI missing certificate-authority-data value
3 participants