Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

German translation #37

Merged
merged 1 commit into from
Aug 7, 2014
Merged

German translation #37

merged 1 commit into from
Aug 7, 2014

Conversation

scento
Copy link
Contributor

@scento scento commented Aug 2, 2014

  • Please review the annotations related to localization best-practices and fix them if possible.
  • I can't test the "look-and-feel" of the application after the sign-up-process, since I am unable to connect to my server (issue Unable to login to ownCloud #19, Unable to login to Baikal #22).
  • I would appreciate some response of someone testing the UI usability with a Flock Sync account.
  • It would be nice if the UI designers respect the long words in some non-English languages...

@rhodey
Copy link
Contributor

rhodey commented Aug 3, 2014

Thanks for this @scento

I will make it my goal for tomorrow to improve Flock according to the localization best practices and merge this pull :)

@scento
Copy link
Contributor Author

scento commented Aug 7, 2014

This request is mergeable without any codebase changes. It seems as if the announced refactoring needs some time, so I would appreciate a quick merge to extend the possible userbase by breaking language barriers.

@rhodey
Copy link
Contributor

rhodey commented Aug 7, 2014

Sorry for the hold up @scento, I wasn't able to work on the project at all for the past few days. Back to full time now!

rhodey added a commit that referenced this pull request Aug 7, 2014
@rhodey rhodey merged commit f11fe64 into signalapp:master Aug 7, 2014
@rhodey
Copy link
Contributor

rhodey commented Sep 30, 2014

@scento I spent some time yesterday removing unused strings from the project and modifying existing strings to use placeholders as you recommended, see a479eaa. Thanks again for your contribution :) if you are interested in continuing to help with the German localization please consider checking out the Flock Transifex page.

Even though the German translations for Flock are complete I cannot myself upload them to Transifex because then I would be in charge of maintaining the translation, a task I'm not very qualified for. If you were to open a German language request on the Flock Transifex project I would certainly approve it, this would would allow you to upload strings within the /values-de/strings.xml file you authored as well as provide translations for any future strings added to the app.

"It would be nice if the UI designers respect the long words in some non-English languages" - In reviewing strings.xml I noticed that the Server Tests UI has a lot of problems with this, I think this UI is already pretty poor so will keep the string length in mind when redesigning.

@rhodey rhodey mentioned this pull request Sep 30, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants