Set messageKeysLimit to unlimited if communicating with our devices #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottnonnenberg
force-pushed
the
message-keys-limit
branch
2 times, most recently
from
443e30f
to
592b7c6
Compare
scottnonnenberg
force-pushed
the
message-keys-limit
branch
from
592b7c6
to
39a5b34
Compare
michaelkirk
approved these changes
Aug 4, 2017
libtextsecure/outgoing_message.js
Outdated
| var sessionCipher = new libsignal.SessionCipher(textsecure.storage.protocol, address); | ||
|
|
||
| var ourNumber = textsecure.storage.user.getNumber(); | ||
| var theirNumber = address.toString().split('.')[0]; |
There was a problem hiding this comment.
can this just be theirNumber = number?
There was a problem hiding this comment.
Given that it is generated from the plain 'address', I suppose. My attempt at extreme clarity made things harder to read?? Whaa? :0)
This was referenced Aug 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Dependent on the work in this PR: signalapp/libsignal-protocol-javascript#29. Need to merge that PR and pulldist/libsignal-protocol.jsfrom that project into this PR.This PR uses the new ability to set the
messageKeysLimitonSessionCipherto remove the limit when communicating with your own devices. We only do this forSessionCipherobjects which are used for encryption/decryption - there are a number of other instantiations which are used entirely to do session management.A number of open issues reference this error "Too many message keys for chain": https://github.com/WhisperSystems/Signal-Desktop/issues?utf8=%E2%9C%93&q=is%3Aissue%20is%3Aopen%20%22Too%20many%20message%20keys%20for%20chain%22
Hopefully these changes will fix that issue. At the very least it will help us get at the root problem.