This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
Add an option to control remote config watch #1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dani Louca <[email protected]>
dloucasfx
requested review from
asuresh4,
jchengsfx,
jrcamp,
keitwb and
mstumpfx
as code owners
keitwb
approved these changes
Apr 21, 2021
|
@dloucasfx ok* if you merge this so we can have a new release tomorrow (unless it's not time sensitive)? |
|
@rmfitzpatrick yes, it's ready to be merged by I was hoping to get the CI fixed so we can gave a green PR |
|
I believe the CI failure is a known issue though I'm not sure the proposed workaround is viable for us - jeremylong/DependencyCheck#3307 |
|
@keitwb I don't believe @jchengsfx has the cycles to release today and I don't have my environment setup (or access). Would you be able to verify this is ok to land and cut a new release to meet a compliance commitment? |
|
I think it's safe to go ahead and merge it, but I will wait for the green light from @keitwb |
|
@dloucasfx I reran and the job passed (it's waiting for ssh sessions to end). |
rmfitzpatrick
pushed a commit
that referenced
this pull request
Apr 23, 2021
Deprecation Notice: * SA deprecation notice for April 15 GA (#1720) * Pull deprecation notice to integrations repo (#1721) Changes: * prometheus-exporter monitor: Don't set timestamp (#1703) * Update ingest-protocols lib (#1704) * sfxcollectd: Fix single item handling with #flatten (#1705) * Allow non defined in collectd/jenkins metrics (#1706) * writer: Sanitize token in HTTP error logs (#1710) * excludeJobMetrics parameter available on collectd-jenkins v2.4.0 (#1712) + Update scripts, docs, and CI for main (#1724) * Add an option to control remote config watch (#1730) * Security updates for third-party dependencies Breaking Changes: * Use static 404 for unsupported signalfx-forwarder paths instead of 200 (#1731)
Merged
rmfitzpatrick
pushed a commit
that referenced
this pull request
Apr 23, 2021
Deprecation Notice: * SA deprecation notice for April 15 GA (#1720) * Pull deprecation notice to integrations repo (#1721) Changes: * prometheus-exporter monitor: Don't set timestamp (#1703) * Update ingest-protocols lib (#1704) * sfxcollectd: Fix single item handling with #flatten (#1705) * Allow non defined in collectd/jenkins metrics (#1706) * writer: Sanitize token in HTTP error logs (#1710) * excludeJobMetrics parameter available on collectd-jenkins v2.4.0 (#1712) * Update scripts, docs, and CI for main (#1724) * Add an option to control remote config watch (#1730) * Security updates for third-party dependencies Breaking Changes: * Use static 404 for unsupported signalfx-forwarder paths instead of 200 (#1731)
rmfitzpatrick
added a commit
that referenced
this pull request
Apr 23, 2021
Deprecation Notice: * SA deprecation notice for April 15 GA (#1720) * Pull deprecation notice to integrations repo (#1721) Changes: * prometheus-exporter monitor: Don't set timestamp (#1703) * Update ingest-protocols lib (#1704) * sfxcollectd: Fix single item handling with #flatten (#1705) * Allow non defined in collectd/jenkins metrics (#1706) * writer: Sanitize token in HTTP error logs (#1710) * excludeJobMetrics parameter available on collectd-jenkins v2.4.0 (#1712) * Update scripts, docs, and CI for main (#1724) * Add an option to control remote config watch (#1730) * Security updates for third-party dependencies Breaking Changes: * Use static 404 for unsupported signalfx-forwarder paths instead of 200 (#1731)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dani Louca [email protected]