Retry datapoint submissions for temporary errors #1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmfitzpatrick
requested review from
asuresh4,
jeffreyc-splunk,
jrcamp,
keitwb and
mstumpfx
as code owners
rmfitzpatrick
force-pushed
the
retry_transient_connection_errors
branch
2 times, most recently
from
d100001
to
1a294f6
Compare
rmfitzpatrick
force-pushed
the
retry_transient_connection_errors
branch
from
0c4318b
to
dbfdd33
Compare
keitwb
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EOF and similar connection errors are common but generally don't prevent successful retried submissions. These changes determine if httpsink's
AddDatapoints()calls fail for retryable reasons and try once more before dropping points.