This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
[monitor/processlist] Fix process status in windows #2063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manang-splunk
requested review from
asuresh4,
jeffreyc-splunk,
keitwb,
mstumpfx,
rmfitzpatrick and
a team
as code owners
manang-splunk
force-pushed
the
processlist
branch
from
6c196f0
to
ab9aff0
Compare
|
@manang-splunk Can you fix the lint error & try to format the newlines correctly so the diff isn't so drastic? |
manang-splunk
force-pushed
the
processlist
branch
3 times, most recently
from
add57f9
to
fc95ce3
Compare
@mstumpfx Pushed the changes accordingly. |
mstumpfx
reviewed
Jan 11, 2022
mstumpfx
reviewed
Jan 11, 2022
|
Thanks for fixing lint & newline issue @manang-splunk |
manang-splunk
force-pushed
the
processlist
branch
from
fc95ce3
to
16471c3
Compare
mstumpfx
approved these changes
Jan 12, 2022
manang-splunk
force-pushed
the
processlist
branch
from
16471c3
to
37335b3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:-
Fixed process status in windows. We are determining the process status depending upon the state of threads as the process' WMI query does not return status. If all the threads are in the waiting state then the process status will be “S” (sleeping) otherwise it will be “R” (running).
Testing:-
windows server 2012