k8s events monitor handle empty event type #2282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dani Louca <[email protected]>
dloucasfx
requested review from
keitwb,
asuresh4,
rmfitzpatrick and
a team
as code owners
tigrannajaryan
approved these changes
Jun 17, 2022
rmfitzpatrick
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have seen instances where the k8s event is coming in with empty
reason, this causes the backend sfx event ingest to drop the event asEventTypeis required .This PR checks if
reasonis not set and set a default valueunknown_reasonSigned-off-by: Dani Louca [email protected]