Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update K8s cluster metadata #2800

Merged
merged 2 commits into from
May 8, 2023
Merged

Update K8s cluster metadata #2800

merged 2 commits into from
May 8, 2023

Conversation

theletterf
Copy link
Contributor

Updates the K8s cluster monitor metadata to reflect that kubernetes.stateful_set.desired and kubernetes.stateful_set.ready are now default metrics.

@theletterf theletterf requested review from a team as code owners May 4, 2023 10:37
@atoulme
Copy link
Contributor

atoulme commented May 4, 2023

Please run scripts/docs/make-docs to regenerate docs.

@theletterf
Copy link
Contributor Author

@atoulme I'm stuck. Can't run the script. Could you help?

@jeffreyc-splunk
Copy link
Contributor

@atoulme I'm stuck. Can't run the script. Could you help?

@theletterf I'll try to make the changes and push to your branch.

@jeffreyc-splunk jeffreyc-splunk requested a review from a team as a code owner May 8, 2023 13:49
@jeffreyc-splunk jeffreyc-splunk force-pushed the change-status-stateful-metrics branch from aaf63bc to f8e8d3c Compare May 8, 2023 14:09
@jeffreyc-splunk
Copy link
Contributor

@theletterf I'll try to fix the remaining failures in a separate PR and rebase your branch. For future reference, after making changes to metadata.yaml, you can try running:

$ make dev-image
$ make run-dev-image

# you should be in the dev-image container now
$ make signalfx-agent
$ AGENT_BIN=$(pwd)/signalfx-agent make docs
$ exit

Then check and commit/push the locally changed files.

theletterf and others added 2 commits May 8, 2023 12:15
Updates the K8s cluster monitor metadata to reflect that `kubernetes.stateful_set.desired` and `kubernetes.stateful_set.ready` are now default metrics.
@jeffreyc-splunk jeffreyc-splunk force-pushed the change-status-stateful-metrics branch from f8e8d3c to 9b5624b Compare May 8, 2023 16:15
@atoulme atoulme merged commit a866ae0 into main May 8, 2023
@atoulme atoulme deleted the change-status-stateful-metrics branch May 8, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants