Rename parameter groups for Splunk OTel Collector components #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
change-component-config-groups
branch
from
d9abeee
to
07bc2a1
Compare
Rename the following parameter groups according to [Splunk GDI Specification](https://github.com/signalfx/gdi-specification/blob/main/specification/configuration.md#kubernetes-package-management-solutions): - `otelAgent` -> `agent` - `otelCollector` -> `gateway` - `otelK8sClusterReceiver` -> `clusterReceiver`
dmitryax
force-pushed
the
change-component-config-groups
branch
from
07bc2a1
to
18b699f
Compare
|
I am guessing this change is for more clarity and reducing ambiguity? |
|
Yes. Decision was made here to establish this configuration interface for helm chart and operator prior to declaring GA |
rockb1017
approved these changes
Nov 18, 2021
|
let me see if i can push a commit to here |
|
oh i can. please review @dmitryax |
|
Awesome! Thanks @rockb1017! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the following parameter groups according to Splunk GDI Specification:
otelAgent->agentotelCollector->gatewayotelK8sClusterReceiver->clusterReceiver