Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

field naming #306

Merged
merged 3 commits into from
Nov 18, 2021
Merged

field naming #306

merged 3 commits into from
Nov 18, 2021

Conversation

rockb1017
Copy link
Contributor

No description provided.

@rockb1017 rockb1017 requested review from a team as code owners November 18, 2021 18:02
@dmitryax
Copy link
Contributor

dmitryax commented Nov 18, 2021

Can you please mention this in CHANGELOG?

@dmitryax
Copy link
Contributor

Functional tests are failing now. Should they get updated field names as well?

Copy link
Contributor

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmitryax dmitryax merged commit 47a70e6 into signalfx:main Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants