remove collectd/df monitor

internal/signalfx-agent/pkg/core/modules_linux.go

@@ -16,7 +16,6 @@ import (
 	_ "github.com/signalfx/signalfx-agent/pkg/monitors/collectd/cpu"
 	_ "github.com/signalfx/signalfx-agent/pkg/monitors/collectd/cpufreq"
 	_ "github.com/signalfx/signalfx-agent/pkg/monitors/collectd/custom"
-	_ "github.com/signalfx/signalfx-agent/pkg/monitors/collectd/df"
 	_ "github.com/signalfx/signalfx-agent/pkg/monitors/collectd/disk"
 	_ "github.com/signalfx/signalfx-agent/pkg/monitors/collectd/genericjmx"
 	_ "github.com/signalfx/signalfx-agent/pkg/monitors/collectd/hadoopjmx"

internal/signalfx-agent/pkg/monitors/filesystems/metadata.yaml

@@ -13,28 +13,6 @@ monitors:
      - type: filesystems
        hostFSPath: /hostfs
     ```
-
-    ## Migrating from collectd/df
-    The `collectd/df` monitor is being deprecated in favor of the `filesystems`
-    monitor.  While the `collectd/df` monitor will still be available in
-    5.0, it is recommended that you switch to the `filesystems` monitor soon
-    after upgrading.  There are a few incompatibilities to be aware of between
-    the two monitors:
-
-     - `collectd/df` used a dimension called `plugin_instance` to identify the
-       mount point or device of the filesystem.  This dimension is completely
-       removed in the `filesystems` monitor and replaced by the `mountpoint`
-       and `device` dimensions.  You no longer have to select between the two
-       (the `reportByDevice` option on `collectd/df`) as both are always
-       reported.
-
-     - The mountpoints in the `plugin_instance` dimension of `collectd/df`
-       were reported with `-` instead of the more conventional `/` separated
-       path segments.  The `filesystems` monitor always reports mountpoints in
-       the `mountpoint` dimension and uses the conventional `/` separator.
-
-     - The `collectd/df` plugin set a dimension `plugin: df` on all datapoints,
-       but `filesystems` has no such comparable dimension.
   metrics:
     df_complex.free:
       description: Free disk space in bytes

pkg/receiver/smartagentreceiver/config.go

@@ -38,7 +38,7 @@ var (
 	errDimensionClientValue = fmt.Errorf("dimensionClients must be an array of compatible exporter names")
 	nonWindowsMonitors      = map[string]bool{
 		"collectd/activemq": true, "collectd/apache": true, "collectd/cassandra": true, "collectd/chrony": true,
-		"collectd/cpu": true, "collectd/cpufreq": true, "collectd/custom": true, "collectd/df": true, "collectd/disk": true,
+		"collectd/cpu": true, "collectd/cpufreq": true, "collectd/custom": true, "collectd/disk": true,
 		"collectd/genericjmx": true, "collectd/hadoopjmx": true, "collectd/kafka": true, "collectd/kafka_consumer": true,
 		"collectd/kafka_producer": true, "collectd/load": true, "collectd/memcached": true, "collectd/memory": true,
 		"collectd/mysql": true, "collectd/netinterface": true, "collectd/nginx": true, "collectd/php-fpm": true,