check if monitor accepts endpoints before setting host/port #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstumpfx
force-pushed
the
sa-monitor-creation
branch
3 times, most recently
from
47f022c
to
1c1ec81
Compare
mstumpfx
force-pushed
the
sa-monitor-creation
branch
5 times, most recently
from
6e0ad30
to
02aea8c
Compare
Only select smart-agent monitors can be created via endpoints. This is defined as a struct tag on the monitor configs "acceptsEndpoints". In the case where we attempt to set Host/Port on a monitor that has it's "acceptsEndpoints" value set to false, an error occurs and we do not create the monitor. This change would create the monitor but avoid setting the Host/Port fields. This allows the receiver creator to create any smart-agent monitor.
mstumpfx
force-pushed
the
sa-monitor-creation
branch
from
02aea8c
to
a7b1fdc
Compare
rmfitzpatrick
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only select smart-agent monitors can be created via endpoints. This is
defined as a struct tag on the monitor configs "acceptsEndpoints". In
the case where we attempt to set Host/Port on a monitor that has it's
"acceptsEndpoints" value set to false, an error occurs and we do not
create the monitor.
This change would create the monitor but avoid setting the
Host/Port fields. This allows the receiver creator to
create any smart-agent monitor with receiver creator.