Add support for multiple config arguments #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@crobert-1 can you please take a look at the failing integration test |
pmcollins
reviewed
May 19, 2022
pmcollins
reviewed
May 20, 2022
pmcollins
reviewed
May 20, 2022
pmcollins
reviewed
May 20, 2022
dmitryax
reviewed
May 20, 2022
pmcollins
reviewed
May 20, 2022
crobert-1
force-pushed
the
support_multiple_configs
branch
from
78843a8
to
aa48708
Compare
crobert-1
force-pushed
the
support_multiple_configs
branch
4 times, most recently
from
f56a20c
to
aa48708
Compare
|
|
|
I'd strongly recommend adding an integration test that uses multiple configs to be able to better vet this over time. Maybe one file for a host metrics receiver, one for a processor, and another for an exporter? |
crobert-1
force-pushed
the
support_multiple_configs
branch
from
4551b27
to
fa39693
Compare
Added an integration test to cover this case, thanks! |
crobert-1
force-pushed
the
support_multiple_configs
branch
2 times, most recently
from
b97b5f3
to
1150486
Compare
crobert-1
force-pushed
the
support_multiple_configs
branch
from
1150486
to
64f2a02
Compare
The core distribution of the collector now supports multiple "--config" input arguments, so this change updates the Splunk distro to also support this. Testing has also been added to ensure the config server works for multiple files, flag parsing works as expected, and the collector can properly use multiple input config files.
Moving the flags into a single encapsulated struct helps organization of variables and testability of the code.
- Encapsulate flags in single structure - Remove getter methods that don't have any extra value - Handle invalid flags passed in - Mark variable as const - Update CHANGELOG
- Comment why CLI flag usage strings are empty - Remove go import replace statement - Assert error contents in tests
-Add locking to config server so it doesn't need to be shutdown and restarted, but can just be started and use references to serve configs. - Add integration test to make sure collector can be run with multiple config files
crobert-1
force-pushed
the
support_multiple_configs
branch
from
64f2a02
to
8bca9be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core distribution of the collector now supports multiple "--config" input arguments, so this change updates the Splunk
distro to also support this. This change also adds new flag parsing functionality to use golang's flag library, instead of manual parsing. Testing has also been added to ensure the config server works for multiple files, flag parsing works as expected, and the collector can properly use multiple input config files.