-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename splunk_config_linux.yaml to gateway_config.yaml #170
Conversation
I'm confused about splunk-otel-collector/cmd/otelcol/main.go Line 42 in 758688e
I feel like defaultDockerSAPMConfig, etc. should be renamed to defaultGatewayConfig to make it more clear. |
hm yeah, some of the wording around these probably needs to be changed. I would think for the install sections we would want a section for using collector as a gateway and a section for using collector as an agent. |
Codecov Report
@@ Coverage Diff @@
## main #170 +/- ##
==========================================
- Coverage 88.62% 88.41% -0.21%
==========================================
Files 16 16
Lines 958 958
==========================================
- Hits 849 847 -2
- Misses 76 77 +1
- Partials 33 34 +1
Continue to review full report at Codecov.
|
@@ -16,7 +16,7 @@ SERVICE_GROUP="splunk-otel-collector" | |||
|
|||
OTELCOL_INSTALL_PATH="/usr/bin/otelcol" | |||
CONFIG_REPO_PATH="$REPO_DIR/cmd/otelcol/config/collector/agent_config.yaml" | |||
CONFIG_INSTALL_PATH="/etc/otel/collector/splunk_config_linux.yaml" | |||
CONFIG_INSTALL_PATH="/etc/otel/collector/gateway_config.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the default config file in the deb/rpm packages, maybe we just package the file as config.yaml
instead of gateway_config.yaml
. We'll then need to add the SPLUNK_CONFIG=/etc/otel/collector/config.yaml
env var to the collector service environment file to override whatever is the default in main.go. I can make the necessary changes after this PR is merged.
I used
rg "splunk_config_linux.yaml" -l | xargs sed -i '' "s/splunk_config_linux.yaml/gateway_config.yaml/g"
I'm not sure if this needs to be changed elsewhere.