Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom config option to linux installer script #1806

Merged
merged 3 commits into from
Jul 26, 2022

Conversation

jeffreyc-splunk
Copy link
Contributor

No description provided.

@jeffreyc-splunk jeffreyc-splunk marked this pull request as ready for review July 25, 2022 19:53
@jeffreyc-splunk jeffreyc-splunk requested review from a team as code owners July 25, 2022 19:53
@rmfitzpatrick
Copy link
Contributor

You may want to document this in https://github.com/signalfx/splunk-otel-collector/blob/main/docs/getting-started/linux-installer.md#collector-configuration ?

@jeffreyc-splunk
Copy link
Contributor Author

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@aurbiztondo-splunk aurbiztondo-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of minor comments re. wording.

@jeffreyc-splunk jeffreyc-splunk merged commit b864c1e into main Jul 26, 2022
@delete-merged-branch delete-merged-branch bot deleted the installer-config-option branch July 26, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants