-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support gateway mode for linux installer #187
Conversation
Codecov Report
@@ Coverage Diff @@
## main #187 +/- ##
=======================================
Coverage 89.10% 89.10%
=======================================
Files 18 18
Lines 1010 1010
=======================================
Hits 900 900
Misses 77 77
Partials 33 33 Continue to review full report at Codecov.
|
Can we make agent vs gateway explicit instead of inferring based on fluentd option? ie, have an option |
Actually.. we would probably need to do something similar to how helm chart works as you may want both agent and gateway at the same time. So it'd probably need to be something like |
@jrcamp Which config file should the collector service be configured for if we allow enabling "both agent and gateway at the same time"? Also, other than setting the |
86f358d
to
0dd4ca8
Compare
0dd4ca8
to
6af918e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- should support one mode or the other and should default to agent. Besides configuration, everything else should be the same.
Though what do you do if you want to monitor the host your gateway is running on if you can't install the agent? 😛 I don't think that's covered today is it? It means there's 3 states (which is what the helm chart covers). agent, gateway, agent + gateway. |
@jrcamp Sorry, I'm still not understanding how we run the collector in both modes at the same time on the same host. Are you suggesting that we run 2 separate collector services (one for agent mode and one for gateway), or is there a way to run a single collector service with both agent and gateway configs? |
@jchengsfx I think he means a tertiary config, where the behavior is like the gateway, but also has receivers enabled like the host metrics receiver, so that the host the gateway is running on is also monitored. I could also see us just enabling this behavior by default in the gateway config. If not, maybe we should at least doc it. |
Correct. I believe there are APM-only customers (though those might actually come with host metrics for free, I can't remember). |
Ok, thanks. We can add a third mode in a separate PR, maybe something like |
--mode <agent|gateway>
option (defaults to agent)SPLUNK_CONFIG
env var for the collector service toagent_config.yaml
if running the installer script with--mode agent
, orgateway_config.yaml
if--mode gateway
--mode
and--without-fluentd
options