Replace usage of Map.Insert* and Map.Update* with Map.Upsert #1957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
remove-insert
branch
from
8d3569c
to
6814a6d
Compare
bogdandrutu
approved these changes
Sep 9, 2022
rmfitzpatrick
approved these changes
Sep 9, 2022
atoulme
approved these changes
Sep 9, 2022
hughesjj
pushed a commit
that referenced
this pull request
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the preparation for removing Map.Update*/Insert* open-telemetry/opentelemetry-collector#5998.
All the usages of Insert are intended to be applied on maps with absent keys, so it's safe to replace them with Upsert.