-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include splunk-otel-js in auto instrumentation deb/rpm #3540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffreyc-splunk
force-pushed
the
new-auto-instrumentation
branch
2 times, most recently
from
August 25, 2023 18:50
bb675a3
to
8299e20
Compare
jeffreyc-splunk
force-pushed
the
package-splunk-otel-js
branch
from
August 25, 2023 18:53
34fed48
to
47b842b
Compare
atoulme
approved these changes
Aug 28, 2023
jeffreyc-splunk
force-pushed
the
new-auto-instrumentation
branch
from
August 28, 2023 22:28
8299e20
to
a3b57c4
Compare
jeffreyc-splunk
force-pushed
the
package-splunk-otel-js
branch
from
August 28, 2023 22:50
47b842b
to
c9c53da
Compare
jeffreyc-splunk
changed the title
DNM: Include splunk-otel-js in auto instrumentation deb/rpm
Include splunk-otel-js in auto instrumentation deb/rpm
Aug 28, 2023
jeffreyc-splunk
changed the base branch from
new-auto-instrumentation
to
zero-config-dev
August 29, 2023 14:31
jeffreyc-splunk
force-pushed
the
package-splunk-otel-js
branch
from
August 29, 2023 14:41
c9c53da
to
c3af713
Compare
jeffreyc-splunk
force-pushed
the
package-splunk-otel-js
branch
from
August 29, 2023 14:43
c3af713
to
25e2bc8
Compare
jeffreyc-splunk
added a commit
that referenced
this pull request
Sep 1, 2023
* Add systemd sample file to splunk-otel-auto-instrumention * Update tests for new libsplunk.so * Include splunk-otel-js in auto instrumentation deb/rpm * Include default /etc/splunk/zeroconfig_node.conf in deb/rpm packages
jeffreyc-splunk
added a commit
that referenced
this pull request
Sep 1, 2023
* Add systemd sample file to splunk-otel-auto-instrumention * Update tests for new libsplunk.so * Include splunk-otel-js in auto instrumentation deb/rpm * Include default /etc/splunk/zeroconfig_node.conf in deb/rpm packages
jeffreyc-splunk
added a commit
that referenced
this pull request
Sep 7, 2023
* Add systemd sample file to splunk-otel-auto-instrumention * Update tests for new libsplunk.so * Include splunk-otel-js in auto instrumentation deb/rpm * Include default /etc/splunk/zeroconfig_node.conf in deb/rpm packages
jeffreyc-splunk
added a commit
that referenced
this pull request
Sep 8, 2023
* Add systemd sample file to splunk-otel-auto-instrumention * Update tests for new libsplunk.so * Include splunk-otel-js in auto instrumentation deb/rpm * Include default /etc/splunk/zeroconfig_node.conf in deb/rpm packages
jeffreyc-splunk
added a commit
that referenced
this pull request
Sep 14, 2023
* Add systemd sample file to splunk-otel-auto-instrumention * Update tests for new libsplunk.so * Include splunk-otel-js in auto instrumentation deb/rpm * Include default /etc/splunk/zeroconfig_node.conf in deb/rpm packages
jeffreyc-splunk
added a commit
that referenced
this pull request
Sep 21, 2023
* Add systemd sample file to splunk-otel-auto-instrumention * Update tests for new libsplunk.so * Include splunk-otel-js in auto instrumentation deb/rpm * Include default /etc/splunk/zeroconfig_node.conf in deb/rpm packages
jeffreyc-splunk
added a commit
that referenced
this pull request
Sep 25, 2023
* Add systemd sample file to splunk-otel-auto-instrumention * Update tests for new libsplunk.so * Include splunk-otel-js in auto instrumentation deb/rpm * Include default /etc/splunk/zeroconfig_node.conf in deb/rpm packages
jeffreyc-splunk
added a commit
that referenced
this pull request
Sep 26, 2023
* Add systemd sample file to splunk-otel-auto-instrumention * Update tests for new libsplunk.so * Include splunk-otel-js in auto instrumentation deb/rpm * Include default /etc/splunk/zeroconfig_node.conf in deb/rpm packages
jeffreyc-splunk
added a commit
that referenced
this pull request
Oct 3, 2023
* Add systemd sample file to splunk-otel-auto-instrumention * Update tests for new libsplunk.so * Include splunk-otel-js in auto instrumentation deb/rpm * Include default /etc/splunk/zeroconfig_node.conf in deb/rpm packages
jeffreyc-splunk
added a commit
that referenced
this pull request
Oct 3, 2023
* Add systemd sample file to splunk-otel-auto-instrumention * Update tests for new libsplunk.so * Include splunk-otel-js in auto instrumentation deb/rpm * Include default /etc/splunk/zeroconfig_node.conf in deb/rpm packages
jeffreyc-splunk
added a commit
that referenced
this pull request
Oct 9, 2023
* Add systemd sample file to splunk-otel-auto-instrumention * Update tests for new libsplunk.so * Include splunk-otel-js in auto instrumentation deb/rpm * Include default /etc/splunk/zeroconfig_node.conf in deb/rpm packages
jeffreyc-splunk
added a commit
that referenced
this pull request
Oct 11, 2023
* Add systemd sample file to splunk-otel-auto-instrumention * Update tests for new libsplunk.so * Include splunk-otel-js in auto instrumentation deb/rpm * Include default /etc/splunk/zeroconfig_node.conf in deb/rpm packages
jeffreyc-splunk
added a commit
that referenced
this pull request
Oct 16, 2023
* Add systemd sample file to splunk-otel-auto-instrumention * Update tests for new libsplunk.so * Include splunk-otel-js in auto instrumentation deb/rpm * Include default /etc/splunk/zeroconfig_node.conf in deb/rpm packages
jeffreyc-splunk
added a commit
that referenced
this pull request
Oct 16, 2023
* Add systemd sample file to splunk-otel-auto-instrumention * Update tests for new libsplunk.so * Include splunk-otel-js in auto instrumentation deb/rpm * Include default /etc/splunk/zeroconfig_node.conf in deb/rpm packages
jeffreyc-splunk
added a commit
that referenced
this pull request
Oct 16, 2023
* Add systemd sample file to splunk-otel-auto-instrumention * Update tests for new libsplunk.so * Include splunk-otel-js in auto instrumentation deb/rpm * Include default /etc/splunk/zeroconfig_node.conf in deb/rpm packages
jeffreyc-splunk
added a commit
that referenced
this pull request
Oct 16, 2023
* Add systemd sample file to splunk-otel-auto-instrumention * Update tests for new libsplunk.so * Include splunk-otel-js in auto instrumentation deb/rpm * Include default /etc/splunk/zeroconfig_node.conf in deb/rpm packages
jeffreyc-splunk
added a commit
that referenced
this pull request
Oct 18, 2023
* Add systemd sample file to splunk-otel-auto-instrumention * Update tests for new libsplunk.so * Include splunk-otel-js in auto instrumentation deb/rpm * Include default /etc/splunk/zeroconfig_node.conf in deb/rpm packages
atoulme
added a commit
that referenced
this pull request
Oct 18, 2023
* [DNM] Zero-config C code to inject environment variables for Java and Node.js (#3514) * Remove sending a metric as part of auto-instrumentation (#3482) * refactor the code to inject allowed env vars * latest after pair programming * latest after review and pairing * only inject env vars for java and nodejs programs. Apply env vars from different files for java and nodejs * remove docker interactive and tty flags * wip * use arch var to set the name of the file to copy * make tests pass on arm64 * try to support arm * build for the proper platform * fix package build * review with Jason, test for env vars overrides * Make ALLOWED_ENV_VARS a single string defined through the preprocessor * Update instrumentation/tests/java/Dockerfile Co-authored-by: Jeff Cheng <[email protected]> * load preload file same way as java test * move file locations to macros * use n functions to handle strings when possible --------- Co-authored-by: Jeff Cheng <[email protected]> * Add systemd sample file to splunk-otel-auto-instrumention (#3506) * Add systemd sample file to splunk-otel-auto-instrumention * Update manual instructions * Include default /etc/splunk/zeroconfig_java.conf in deb/rpm packages * Update tests for new libsplunk.so * Run auto instrumentation workflow for the zero-config-dev branch * Include splunk-otel-js in auto instrumentation deb/rpm (#3540) * Add systemd sample file to splunk-otel-auto-instrumention * Update tests for new libsplunk.so * Include splunk-otel-js in auto instrumentation deb/rpm * Include default /etc/splunk/zeroconfig_node.conf in deb/rpm packages * Add tests for express instrumentation (#3566) * Update installer script for systemd auto instrumentation (#3536) * Rename zeroconfig config files (#3682) * Update ZC docs and tests for manual installation/configuration (#3700) * Update docs * Update splunk-otel-js to v2.4.2 * Combine sample systemd config files * Install splunk-otel-js globally for tests * Update deps installation for node tests * Update splunk-otel-js to v2.4.4 * Update linux-manual.md * Update test for centos/oraclelinux 7 arm64 --------- Co-authored-by: Anna U <[email protected]> * Update otlp endpoint for linux installer script (#3761) * Update otlp endpoint for linux installer script * remove 0.0.0.0 * Add debian bookworm for instrumentation tests * Update CHANGELOG.md --------- Co-authored-by: Antoine Toulme <[email protected]> Co-authored-by: Anna U <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tgz
from https://github.com/signalfx/splunk-otel-js/releases insplunk-otel-auto-instrumentation
deb/rpm packages/etc/splunk/zeroconfig_node.conf
NODE_OPTIONS=-r @splunk/otel/instrument
with instructions on how to manually install thesplunk-otel-js
package and enable/configure instrumentation for systemd services (eventually, the installers would automatically handle these steps)splunk-otel-js
version and open a PR (similar tosplunk-otel-javaagent
)TODO: Add tests with node.js app