Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a deprecation notice to collectd-etcd #3990

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Dec 1, 2023

This PR has a companion PR on the collectd-etcd repository:
signalfx/collectd-etcd#7

The collectd plugin doesn't support modern versions of etcd and Prometheus should be used instead.

This PR adds a warning notice when starting the monitor to let users know that this monitor is now deprecated and may be removed soon.

@atoulme atoulme requested review from a team as code owners December 1, 2023 04:40
@atoulme
Copy link
Contributor Author

atoulme commented Dec 1, 2023

I opted to point out to the etcd plugin which is a thin wrapper around the prometheus endpoint scraper.

@atoulme atoulme merged commit 255e47e into main Dec 1, 2023
5 checks passed
@delete-merged-branch delete-merged-branch bot deleted the deprecate_etcd_plugin branch December 1, 2023 21:58
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants