Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated netinterface monitor #3991

Merged
merged 1 commit into from
Jan 3, 2024
Merged

remove deprecated netinterface monitor #3991

merged 1 commit into from
Jan 3, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Dec 1, 2023

Description:

This removes the deprecated netinterface monitor. This component was deprecated 3 years 9 months ago. As noted in the documentation of this monitor, the net-io monitor should be used instead:

    **This monitor is deprecated in favor of the `net-io` monitor. Please
    switch to that monitor as this monitor will be removed in a future release
    of the agent.**  Note that the `net-io` monitor uses the `interface`
    dimension to identify the network card instead of the `plugin_instance`
    dimension, but otherwise the metrics are the same.

@atoulme atoulme requested review from a team as code owners December 1, 2023 04:44
Copy link
Contributor

@rmfitzpatrick rmfitzpatrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please replace w/ deprecation notice for at least a release

@atoulme atoulme merged commit fe8b916 into main Jan 3, 2024
45 checks passed
@delete-merged-branch delete-merged-branch bot deleted the remove_netinterface branch January 3, 2024 01:03
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants