Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove collectd/load monitor #3995

Merged
merged 2 commits into from
Jan 3, 2024
Merged

remove collectd/load monitor #3995

merged 2 commits into from
Jan 3, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Dec 1, 2023 •
edited
Loading

Description:

This PR removes the collectd/load monitor in favor of the load monitor. This component was deprecated 3 years 11 months ago.

The collectd/load monitor is deprecated with the following notice:

    **This monitor has been deprecated in favor of the `load` monitor. That
    monitor emits the same metrics and is fully compatible.  This
    `collectd/load` monitor will be removed in a future release of the agent."

@atoulme atoulme requested review from a team as code owners December 1, 2023 05:10
rmfitzpatrick
rmfitzpatrick previously requested changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@rmfitzpatrick rmfitzpatrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please replace w/ logged deprecation notice for at least a release

@atoulme atoulme merged commit aa378c9 into main Jan 3, 2024
44 checks passed
@delete-merged-branch delete-merged-branch bot deleted the remove_load branch January 3, 2024 18:56
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crobert-1 crobert-1 crobert-1 approved these changes

@rmfitzpatrick rmfitzpatrick rmfitzpatrick left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atoulme @rmfitzpatrick @crobert-1