Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove translatesfx #4028

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Remove translatesfx #4028

merged 1 commit into from
Dec 8, 2023

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Dec 8, 2023

Description:
This PR removes translatesfx from the repository. Translatesfx is a tool used to migrate configuration between the smart agent and the OpenTelemetry Collector. As the Smart Agent has now reached end of support, this tool is deprecated and will be removed from the collector next release onwards.

@atoulme atoulme requested review from a team as code owners December 8, 2023 01:32
Copy link
Contributor

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the failing integration test isn't related to this change, but we need to confirm

--- FAIL: TestHelmChartMetricsHappyPath (72.69s)

@atoulme
Copy link
Contributor Author

atoulme commented Dec 8, 2023

It fails on both PRs recently, need to check main build.

@atoulme
Copy link
Contributor Author

atoulme commented Dec 8, 2023

So the build passed on arm because the test skips it there, and it fails on amd64 because it looks for a version of the chart we skipped. I think we can merge this PR as the code doesn't touch this particular execution path, and we need to fix main.

@atoulme atoulme merged commit 7cb1148 into main Dec 8, 2023
130 of 131 checks passed
@delete-merged-branch delete-merged-branch bot deleted the remove_translate_sfx branch December 8, 2023 17:47
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants