discoverybundler: Generate component files from components.go #4066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmfitzpatrick
force-pushed
the
bundledbootstrap
branch
from
5031f77
to
282b37f
Compare
Also adds `make bundle.d` diff check in tests job.
rmfitzpatrick
force-pushed
the
bundledbootstrap
branch
from
282b37f
to
3a7c9ec
Compare
jvoravong
reviewed
Dec 14, 2023
jvoravong
approved these changes
Dec 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
These changes add a new
components.gofile used to generate the previously manually updated bundle_gen and BundledFS parent files (which were renamed)*. They also remove implicit discoverybundler installation w/make bundle.dcalls.Testing:
Existing tests ensure no component changes and added
make bundle.ddiff check in test job can help detect unexpected deviation.