Stop sending metrics reported by batch processor #4273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
disable-excessive-batch-metrics
branch
from
eb378ce
to
d1d6701
Compare
crobert-1
requested changes
Feb 7, 2024
There was a problem hiding this comment.
Do we want to drop these in the logs_config_linux.yaml config as well?
There is no internal metrics pipeline there |
crobert-1
approved these changes
Feb 7, 2024
dmitryax
force-pushed
the
disable-excessive-batch-metrics
branch
from
d1d6701
to
a7197f0
Compare
The batch processor metrics are not being used in any default dashboards but signicantly contribute towards metric timeseries created on the backend. - otelcol_processor_batch_batch_send_size - otelcol_processor_batch_timeout_trigger_send
dmitryax
force-pushed
the
disable-excessive-batch-metrics
branch
from
a7197f0
to
d4aa7d5
Compare
atoulme
approved these changes
Feb 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The batch processor metrics are not being used in any default dashboards but signicantly contribute towards metric timeseries created on the backend.