[discovery] Enable discovery mode for SQL Server receiver #5109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobert-1
commented
Jul 16, 2024
crobert-1
commented
Jul 16, 2024
cmd/otelcol/config/collector/config.d.linux/receivers/sqlserver.discovery.yaml
Outdated
Show resolved
Hide resolved
jvoravong
reviewed
Jul 17, 2024
Co-authored-by: jvoravong <[email protected]>
jvoravong
approved these changes
Jul 19, 2024
dmitryax
reviewed
Jul 23, 2024
cmd/otelcol/config/collector/config.d.linux/receivers/sqlserver.discovery.yaml
Outdated
Show resolved
Hide resolved
|
Once all comments are addressed and the only tests failing are for TestExpandedDollarSignsViaStandardEnvVar, then feel free to merge. We are in the process of addressing these specific tests in a separate effort. |
dmitryax
approved these changes
Jul 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This changes enables automatic detection of SQL Server instances running in a host, docker, or kubernetes environment. The configuration is set up to automatically discover host and port, but requires username and password for connecting to SQL server. Also, the default metrics need to be updated to no longer match upstream.
Testing:
Tested in k8s env:
Also pulled up OOTB dashboards, updated metrics to match OTEL naming, and they were populated properly with data from my k8s environment.