Discovery observers Start failures should not stop nor crash the collector #5299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5202 the discovery code was changed so the collector ended its start up in case any observer failed to start - this behavior was agreed per conversation. However, the docker observer had a behavior that if it failed to start on mac and Linux it didn't crash as in Windows. This cemented a behavior on the collector that was changed by #5202: the collector started successfully even if the docker observer failed. This change restores the previous behavior while not adding the risk of crashing in observers that failed to start (that's why it is not a simple reverse).
In the future we may want to consider if having a strict discovery mode is desirable. In this mode the user could enter an option to indicate that discovery should fail if any observer or receiver fails to be created or started.