[receiver/discovery] Fix metrics-only collection #5359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I missed some conditions in previous PR. If the receiver was configured on metrics pipeline only with some discovered services, it would block collector shutdown's. This change fixes that. It's not a typical use case to enable it on metrics pipeline only, so we don't need to test it extensively. I'll be covered to some extend in the following PRs.
dmitryax
force-pushed
the
clear-up-metrics-only-run
branch
from
51663e9
to
8dfe064
Compare
atoulme
approved these changes
Sep 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed some conditions in the previous PR. If the receiver was configured only on a metrics pipeline with any discovered services, it would block collector shutdown. This change fixes that. It's not a typical use case to enable it on the metrics pipeline only, so we don't need to test it extensively. It'd require an integration test. I'll be covered to some extent in the following PRs.