Continuous service discovery #5363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
approved these changes
Sep 13, 2024
|
Changes look ok but lint disagrees, please take a look. |
Oh right, I forgot to remove a function that was split |
dmitryax
force-pushed
the
continuous-discovery
branch
from
186bf57
to
1fd26e0
Compare
This change introduces a new way of how the discovery mechanism works. Instead of observing data for the first 10 seconds and creating a static receiver_cretor config from that, it'll be running discovery receiver watching for all supported receivers. Once a new endpoint for any supported service is available, the collector will try to fetch metrics from it. If the collector cannot get metrics from a new service right away, it'll send detailed information about what can be done to enable it to the backend, which will be reflected in the newly discovered services UI. Any services that are successfully discovered will also be reflected in the UI. The collector sends entity events as OTLP logs to deliver information about the discovered services. The new functionality can be enabled with "splunk.continuousDiscovery" feature gate by adding --feature-gates=splunk.continuousDiscovery argument to the otecol command.
dmitryax
force-pushed
the
continuous-discovery
branch
from
1fd26e0
to
20aa0de
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a new way of how the discovery mechanism works. Instead of observing data for the first 10 seconds and creating a static
receiver_cretorconfig from that, it'll be running discovery receiver watching for all supported receivers. Once a new endpoint for any supported service is available, the collector will try to fetch metrics from it. If the collector cannot get metrics from a new service right away, it'll send detailed information about what can be done to enable it to the backend, which will be reflected in the newly discovered services UI. Any services that are successfully discovered will also be reflected in the UI. The collector sends entity events as OTLP logs to deliver information about the discovered services.The new functionality can be enabled with "splunk.continuousDiscovery" feature gate by adding
--feature-gates=splunk.continuousDiscoveryargument to theotecolcommand.