Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choco upgrade should preserve collector service custom env vars #5386

Merged

Conversation

pjanotti
Copy link
Contributor

@pjanotti pjanotti commented Sep 19, 2024

Description:
Choco upgrade should preserve custom environment variables set by the user and should not fail if env vars contain double-quotes.

Link to Splunk idea:

Testing:

Documentation:
N/A

@pjanotti pjanotti changed the title DNM: Choco upgrade should preserve collector service env vars Choco upgrade should preserve collector service custom env vars Sep 19, 2024
@pjanotti pjanotti marked this pull request as ready for review September 19, 2024 17:27
@pjanotti pjanotti requested review from a team as code owners September 19, 2024 17:27
@pjanotti pjanotti merged commit 43f9512 into signalfx:main Sep 19, 2024
206 of 218 checks passed
@pjanotti pjanotti deleted the fix-choco-upgrade-with-custom-env-vars branch September 19, 2024 20:17
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants