Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove enabled flag from startMetrics #429

Merged
merged 3 commits into from
Mar 15, 2022
Merged

fix: remove enabled flag from startMetrics #429

merged 3 commits into from
Mar 15, 2022

Conversation

seemk
Copy link
Collaborator

@seemk seemk commented Mar 15, 2022

Description

Remove the completely unnecessary enabled flag from startMetrics. startMetrics should just start it, for CLI loads the env var is read at instrument.ts instead.

Type of change

Please delete options that are not relevant.

  • Internal change (a change which is not visible to the package consumers)

How Has This Been Tested?

  • Tested manually
  • Added automated tests

Checklist:

  • Unit tests have been added/updated
  • Documentation has been updated
  • Change file has been generated (npm run change:new)
  • Delete this branch (after the PR is merged)

@seemk seemk requested review from a team as code owners March 15, 2022 11:51
@rauno56 rauno56 enabled auto-merge (squash) March 15, 2022 13:06
@rauno56 rauno56 merged commit 5b42126 into main Mar 15, 2022
@rauno56 rauno56 deleted the fix-startmetrics branch March 15, 2022 13:08
@seemk seemk mentioned this pull request Apr 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauno56 rauno56 rauno56 approved these changes

@theletterf theletterf theletterf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seemk @rauno56 @theletterf