Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove jaeger-client #445

Merged
merged 1 commit into from
Apr 21, 2022
Merged

chore: remove jaeger-client #445

merged 1 commit into from
Apr 21, 2022

Conversation

seemk
Copy link
Collaborator

@seemk seemk commented Apr 21, 2022

Not directly used in our code. OTel Jaeger exporter still brings in the package however.

@seemk seemk requested review from a team as code owners April 21, 2022 09:29
@jtmal-signalfx jtmal-signalfx self-requested a review April 21, 2022 10:25
jtmal-signalfx
jtmal-signalfx suggested changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@jtmal-signalfx jtmal-signalfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's pause for a second, and double check if we need any docs changes

@seemk seemk merged commit 4ad7136 into main Apr 21, 2022
@seemk seemk deleted the remove-jaeger-client branch April 21, 2022 16:50
@seemk seemk mentioned this pull request Apr 21, 2022
Merged
@kumachop2 kumachop2 mentioned this pull request Aug 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtmal-signalfx jtmal-signalfx jtmal-signalfx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seemk @jtmal-signalfx