Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export pprof (#517) #523

Merged
merged 4 commits into from
Aug 7, 2022
Merged

feat: export pprof (#517) #523

merged 4 commits into from
Aug 7, 2022

Conversation

seemk
Copy link
Collaborator

@seemk seemk commented Aug 1, 2022

Modification of #517

* refactor: move parseEndpoint into utils

* feat: implement exporting pprof

* fix: add missing attributes

* fix: fix message on debug logging

* fix: force logs endpoint to collector

* feat: take OTLP endpoint for a default

* Change files
@seemk seemk requested review from a team as code owners August 1, 2022 07:28
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2022

Codecov Report

Merging #523 (12f3ba1) into main (0ae014e) will increase coverage by 0.02%.
The diff coverage is 55.76%.

@@            Coverage Diff             @@
##             main     #523      +/-   ##
==========================================
+ Coverage   54.87%   54.90%   +0.02%     
==========================================
  Files          28       28              
  Lines        2409     2426      +17     
  Branches      918      919       +1     
==========================================
+ Hits         1322     1332      +10     
- Misses       1087     1094       +7     
Impacted Files Coverage Δ
src/profiling/types.ts 100.00% <ø> (ø)
src/profiling/OTLPProfilingExporter.ts 48.83% <7.14%> (-9.06%) ⬇️
src/profiling/DebugExporter.ts 30.00% <50.00%> (ø)
src/profiling/utils.ts 89.15% <72.72%> (-10.85%) ⬇️
src/profiling/index.ts 87.65% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ae014e...12f3ba1. Read the comment docs.

Copy link
Contributor

@jtmal-signalfx jtmal-signalfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly cosmetic, so I'm approving, if there's something bigger hiding in there that I should take a deeper look at, let me know.

@seemk
Copy link
Collaborator Author

seemk commented Aug 1, 2022

I moved it from Rauno's branch so I can edit a bit, for example source.event.period should be a label. Basing memory profiling on this branch as well so I can change stuff if necessary.

@seemk
Copy link
Collaborator Author

seemk commented Aug 2, 2022

Additional changes according to the spec:

  • Moved source.event.period from LogRecord to sample labels
  • Serialize unknown lines as -1

Plus

  • The values received from native profiler can't be undefined, removed unnecessary function types.
  • Native side already checks for empty function names, removed adding of (anonymous) due to that

@seemk
Copy link
Collaborator Author

seemk commented Aug 4, 2022

Fixed an issue where the native side was generating all identical stacktraces during the collection step. Happened because the stacktraces array was created outside of the stack line creation loop, thus each stacktrace creation overwrote the same array.

@seemk seemk merged commit 70df9b1 into main Aug 7, 2022
@seemk seemk deleted the pprof-export branch August 7, 2022 14:11
@seemk seemk mentioned this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants