-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: export pprof (#517) #523
Conversation
* refactor: move parseEndpoint into utils * feat: implement exporting pprof * fix: add missing attributes * fix: fix message on debug logging * fix: force logs endpoint to collector * feat: take OTLP endpoint for a default * Change files
Codecov Report
@@ Coverage Diff @@
## main #523 +/- ##
==========================================
+ Coverage 54.87% 54.90% +0.02%
==========================================
Files 28 28
Lines 2409 2426 +17
Branches 918 919 +1
==========================================
+ Hits 1322 1332 +10
- Misses 1087 1094 +7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly cosmetic, so I'm approving, if there's something bigger hiding in there that I should take a deeper look at, let me know.
I moved it from Rauno's branch so I can edit a bit, for example |
Additional changes according to the spec:
Plus
|
Fixed an issue where the native side was generating all identical stacktraces during the collection step. Happened because the stacktraces array was created outside of the stack line creation loop, thus each stacktrace creation overwrote the same array. |
Modification of #517