Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support SPLUNK_REALM #530

Merged
merged 7 commits into from
Aug 26, 2022
Merged

feat: support SPLUNK_REALM #530

merged 7 commits into from
Aug 26, 2022

Conversation

seemk
Copy link
Collaborator

@seemk seemk commented Aug 25, 2022

Description

Add support for realm selection via options or an env var.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Documentation change or requires a documentation update

How Has This Been Tested?

  • Tested manually
  • Added automated tests

Checklist:

  • Unit tests have been added/updated
  • Documentation has been updated
  • Change file has been generated (npm run change:new)
  • Delete this branch (after the PR is merged)

@seemk seemk requested review from a team as code owners August 25, 2022 12:45
docs/advanced-config.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #530 (1965158) into main (70df9b1) will increase coverage by 33.65%.
The diff coverage is 91.93%.

❗ Current head 1965158 differs from pull request most recent head d62e2d5. Consider uploading reports for the commit d62e2d5 to get more accurate results

@@             Coverage Diff             @@
##             main     #530       +/-   ##
===========================================
+ Coverage   54.90%   88.56%   +33.65%     
===========================================
  Files          28       27        -1     
  Lines        2426      918     -1508     
  Branches      919      210      -709     
===========================================
- Hits         1332      813      -519     
+ Misses       1094      105      -989     
Impacted Files Coverage Δ
src/tracing/options.ts 95.52% <90.56%> (-2.40%) ⬇️
src/metrics/index.ts 92.85% <100.00%> (+0.46%) ⬆️
src/profiling/proto/profile.js

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@seemk seemk merged commit 7d96f29 into main Aug 26, 2022
@seemk seemk deleted the add-splunk-realm branch August 26, 2022 09:04
@seemk seemk mentioned this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants