Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for OTEL_EXPORTER_OTLP_PROTOCOL, OTEL_EXPORTER_OTLP_ENDPOINT #599

Merged
merged 2 commits into from
Nov 14, 2022

Conversation

seemk
Copy link
Collaborator

@seemk seemk commented Nov 12, 2022

  • Drop dubious possible values for OTEL_TRACES_EXPORTER, e.g. otlp-splunk which meant the HTTP protobuf exporter.
  • Switching between gRPC and HTTP is now done via OTEL_EXPORTER_OTLP_PROTOCOL and OTEL_EXPORTER_OTLP_TRACES_PROTOCOL with the latter taking precedence as per OTel spec.
  • Add support for OTEL_EXPORTER_OTLP_TRACES_ENDPOINT. Order of precedence: programmatically -> OTEL_EXPORTER_OTLP_TRACES_ENDPOINT -> OTEL_EXPORTER_OTLP_ENDPOINT.
  • It is now possible to specify multiple exporters, separated by commas to OTEL_TRACES_EXPORTER. The only accepted values for now are otlp and console.

@seemk seemk requested review from a team as code owners November 12, 2022 18:46
@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2022

Codecov Report

Base: 82.28% // Head: 83.68% // Increases project coverage by +1.39% 🎉

Coverage data is based on head (37135fa) compared to base (05cc17c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #599      +/-   ##
==========================================
+ Coverage   82.28%   83.68%   +1.39%     
==========================================
  Files          28       28              
  Lines        1118     1140      +22     
  Branches      248      255       +7     
==========================================
+ Hits          920      954      +34     
+ Misses        198      186      -12     
Impacted Files Coverage Δ
src/tracing/options.ts 99.21% <100.00%> (+10.23%) ⬆️
src/utils.ts 95.83% <100.00%> (+1.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@seemk seemk merged commit 1368f53 into main Nov 14, 2022
@seemk seemk deleted the support-otlp-trace-env-vars branch November 14, 2022 10:37
@seemk seemk mentioned this pull request Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants