Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better diagnostic logging configuration #605

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Conversation

seemk
Copy link
Collaborator

@seemk seemk commented Nov 16, 2022

  • New optional option to start: logLevel. Setting it configures the OTel diagnostic console logger with the specified log level.
  • Can also be set via OTEL_LOG_LEVEL. Previously this only set the log level but did not create the logging pipeline.

Fixes:

@seemk seemk requested review from a team as code owners November 16, 2022 11:32
@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2022

Codecov Report

Base: 83.69% // Head: 84.10% // Increases project coverage by +0.40% 🎉

Coverage data is based on head (009f31a) compared to base (c141e58).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #605      +/-   ##
==========================================
+ Coverage   83.69%   84.10%   +0.40%     
==========================================
  Files          28       28              
  Lines        1141     1170      +29     
  Branches      255      265      +10     
==========================================
+ Hits          955      984      +29     
  Misses        186      186              
Impacted Files Coverage Δ
src/start.ts 100.00% <100.00%> (ø)
src/utils.ts 97.18% <100.00%> (+1.34%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@seemk seemk merged commit 0990fb3 into main Nov 16, 2022
@seemk seemk deleted the improve-diag-logging branch November 16, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants