Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support OTEL_METRICS_EXPORTER, OTEL_EXPORTER_OTLP_METRICS_PROTOCOL #614

Merged
merged 3 commits into from
Nov 22, 2022

Conversation

seemk
Copy link
Collaborator

@seemk seemk commented Nov 22, 2022

  • It is now possible to select one more more exporters with OTEL_METRICS_EXPORTER. Currently supported values: otlp, console.
  • Add support for OTEL_EXPORTER_OTLP_METRICS_PROTOCOL. Possible values: grpc (the default) or http/protobuf.

@seemk seemk requested review from a team as code owners November 22, 2022 15:36
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2022

Codecov Report

Base: 84.08% // Head: 84.58% // Increases project coverage by +0.49% 🎉

Coverage data is based on head (c1c73c0) compared to base (1d94317).
Patch coverage: 88.88% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #614      +/-   ##
==========================================
+ Coverage   84.08%   84.58%   +0.49%     
==========================================
  Files          28       28              
  Lines        1169     1213      +44     
  Branches      265      281      +16     
==========================================
+ Hits          983     1026      +43     
- Misses        186      187       +1     
Impacted Files Coverage Δ
src/index.ts 100.00% <ø> (ø)
src/metrics/ConsoleMetricExporter.ts 11.86% <ø> (ø)
src/metrics/index.ts 93.91% <88.88%> (-1.58%) ⬇️
src/detectors/ProcessDetector.ts 89.65% <0.00%> (+3.29%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/metrics/index.ts Outdated Show resolved Hide resolved
@seemk seemk merged commit 0c74524 into main Nov 22, 2022
@seemk seemk deleted the otel-metrics-protocol-envs branch November 22, 2022 15:56
@seemk seemk mentioned this pull request Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants