Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add frame count to profiles #726

Merged
merged 2 commits into from
Apr 26, 2023
Merged

feat: add frame count to profiles #726

merged 2 commits into from
Apr 26, 2023

Conversation

seemk
Copy link
Collaborator

@seemk seemk commented Apr 26, 2023

@seemk seemk requested review from a team as code owners April 26, 2023 09:43
@seemk seemk requested a review from a team as a code owner April 26, 2023 09:45
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +2.32 🎉

Comparison is base (eac236c) 85.99% compared to head (17aa451) 88.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #726      +/-   ##
==========================================
+ Coverage   85.99%   88.31%   +2.32%     
==========================================
  Files          28       28              
  Lines        1264     1267       +3     
  Branches      285      285              
==========================================
+ Hits         1087     1119      +32     
+ Misses        177      148      -29     
Impacted Files Coverage Δ
src/profiling/OTLPProfilingExporter.ts 79.68% <100.00%> (+43.62%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@seemk seemk merged commit cf85a83 into main Apr 26, 2023
@seemk seemk deleted the pprof-frame-count branch April 26, 2023 10:12
@seemk seemk mentioned this pull request May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants