feat: support native builds with Node 20 #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t2t2
approved these changes
Aug 2, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #771 +/- ##
=======================================
Coverage 86.10% 86.10%
=======================================
Files 19 19
Lines 662 662
Branches 151 151
=======================================
Hits 570 570
Misses 92 92 ☔ View full report in Codecov by Sentry. |
Merged
|
@seemk any chance you could add those changes to It looks like it should be enough to just cherry-pick 8cac4f7 merge commit there: Update: There are some conflicts but they looks simple enough to fix. |
lbeschastny
pushed a commit
to lbeschastny/splunk-otel-js
that referenced
this pull request
Aug 2, 2023
* node20 build attempt * enable c++17 * suppress macos warnings * prebuild on node 16 * conditional cpp version * fix conditional * build node20 on node16 * use cppstd14 on macos * binding gyp syntax * remove unnecessary quotes * set cpp version on windows * always use cpp17 on macos
|
Looks like it's not that straightforward. The build in And I'm not sure if it's worth investigating and fixing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And add Node 20 to testing matrix.