Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add @deprecated annotation to deprecated functions #885

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

SevenOutman
Copy link
Contributor

So that user gets editor hints about deprecation (dash-through, comments)

image

@SevenOutman SevenOutman requested review from a team as code owners February 21, 2024 02:30
Copy link

github-actions bot commented Feb 21, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@SevenOutman SevenOutman changed the title refactor: add @deprecate annotation to deprecated functions refactor: add @deprecated annotation to deprecated functions Feb 21, 2024
@SevenOutman SevenOutman force-pushed the fix/startTracing-deprecate-jsdoc branch from 49a4400 to e577f18 Compare February 21, 2024 02:31
@SevenOutman
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

srv-gh-o11y-gdi-cla added a commit to splunk/cla-agreement that referenced this pull request Feb 21, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.97%. Comparing base (ee90b71) to head (e577f18).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #885   +/-   ##
=======================================
  Coverage   85.97%   85.97%           
=======================================
  Files          19       19           
  Lines         670      670           
  Branches      154      154           
=======================================
  Hits          576      576           
  Misses         94       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seemk seemk closed this Aug 29, 2024
@seemk seemk reopened this Aug 29, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2024
@seemk
Copy link
Collaborator

seemk commented Aug 29, 2024

@SevenOutman Thanks for the PR, but the commits need to be signed, else I can't merge.

@SevenOutman SevenOutman force-pushed the fix/startTracing-deprecate-jsdoc branch from e577f18 to eccd78b Compare August 29, 2024 13:45
@SevenOutman SevenOutman requested a review from seemk August 29, 2024 13:49
@seemk seemk merged commit 2310fa5 into signalfx:main Sep 2, 2024
63 of 66 checks passed
@seemk
Copy link
Collaborator

seemk commented Sep 2, 2024

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants